Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Settings and Documentation #758

Merged
merged 459 commits into from
Feb 1, 2024
Merged

Config Settings and Documentation #758

merged 459 commits into from
Feb 1, 2024

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Nov 2, 2023 •
edited
Loading

This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646

Settings migration progress:

  • Initialize LOS
  • Initialize Tours
  • Accessibility
  • Disaggregate Accessibility
  • Work from Home
  • School Location
  • Work Location
  • Shadow Pricing
  • Transit Pass Subsidy
  • Transit Pass Ownership
  • Auto Ownership
  • Vehicle Type Choice
  • Telecommute Frequency
  • Free Parking Eligibility
  • Coordinated Daily Activity Pattern
  • Mandatory Tour Frequency
  • Mandatory Tour Scheduling
  • School Escorting
  • Joint Tour Composition
  • Joint Tour Participation
  • Joint Tour Destination
  • Joint Tour Scheduling
  • Joint Tour Frequency Composition
  • Non-Mandatory Tour Frequency
  • Non-Mandatory Tour Destination Choice
  • Non-Mandatory Tour Scheduling
  • Vehicle Allocation
  • Tour Mode Choice
  • At-work Subtours Frequency
  • At-work Subtour Destination
  • At-work Subtour Mode Choice
  • At-work Subtour Scheduling
  • Intermediate Stop Frequency
  • Trip Purpose
  • Trip Destination Choice
  • Trip Purpose and Destination
  • Trip Scheduling (Probabilistic)
  • Trip Scheduling Choice (Logit Choice)
  • Trip Departure Choice (Logit Choice)
  • Trip Mode Choice
  • Parking Location Choice
  • Write Trip Matrices
  • summarize
  • tour_od_choice
  • Tour Scheduling Probalistic

jpn-- added 30 commits May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes

activitysim/core/configuration/base.py Show resolved Hide resolved
activitysim/core/configuration/filesystem.py Outdated Show resolved Hide resolved
activitysim/abm/models/joint_tour_frequency.py Show resolved Hide resolved
activitysim/abm/models/location_choice.py Show resolved Hide resolved
activitysim/workflows/steps/contrast/load_tables.py Show resolved Hide resolved
i-am-sijia
i-am-sijia reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.

activitysim/core/configuration/base.py Show resolved Hide resolved
@jpn-- jpn-- added the Usability Changes that improve usability label Jan 29, 2024
@dhensle dhensle added the Phase 8 Feature planned for inclusion in Phase 8 release label Jan 30, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a 
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn-- jpn-- merged commit 25e4f6c into ActivitySim:develop Feb 1, 2024
18 checks passed
@jpn-- jpn-- mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-am-sijia i-am-sijia i-am-sijia approved these changes

Assignees

@i-am-sijia i-am-sijia

Labels
Phase 8 Feature planned for inclusion in Phase 8 release Usability Changes that improve usability
Projects
Phase 9 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jpn-- @i-am-sijia @dhensle @vivekyadav26 @navsarmajs