Parking Location Choice Memory Reduction #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-sijia
added a commit
to wsp-sag/activitysim
that referenced
this pull request
Apr 19, 2024
7 tasks
jpn--
added a commit
that referenced
this pull request
Apr 21, 2024
* auto drop vars in choosers table * formatting * vars hardcoded in the custom chooser functions * accidentally committed outputs * skip dropping when tracing * skip dropping if estimation mode * test dropping before interaction df * black * revert drop inplace * cleaning dup codes to function * drop unused columns for logsum calculation * blacken * add drop_unused_columns to compute_settings * check setting before dropping columns * rename method; cherry-pick parking location changes from #849 * protect additional columns not in spec --------- Co-authored-by: Jeff Newman <jeff@driftless.xyz>
|
Changes included in #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused columns in the parking location choice model when creating the interaction dataframe combining alternatives and choosers.
Built on top of the function drop_unused_chooser_columns that is part of #833.