-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C15 - Katrina K #33
base: master
Are you sure you want to change the base?
C15 - Katrina K #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Katrina. Just a few comments on time complexity. For some reason Learn isn't processing the repo you submitted so I can submit a score.
def grouped_anagrams(strings): | ||
""" This method will return an array of arrays. | ||
Each subarray will have strings which are anagrams of each other | ||
Time Complexity: ? | ||
Space Complexity: ? | ||
Time Complexity: O(n log m) | ||
Space Complexity: O(n) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I would say either O(n) for time complexity if words are of limited length or O(n * m log m) if the words can be of arbitrary length because you're processing n words and sort each word of potentially m letters.
def top_k_frequent_elements(nums, k): | ||
""" This method will return the k most common elements | ||
In the case of a tie it will select the first occuring element. | ||
Time Complexity: ? | ||
Space Complexity: ? | ||
Time Complexity: At least O(n) assuming that max() is an O(1) look up but I strongly suspect it isn't | ||
Space Complexity: At least O(n + k) | ||
(Not sure about the big O here becuase I'm not certain how max works in this case) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Because you have a loop going k times and each time you find a maximum of the n
elements. I would say this is O(nk)
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions