chan - rock #2
Open
chan - rock #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 4, 2021
Comment on lines
+13
to
+16
| if (string[index] in bracketMap) { | ||
| stack.push(string[index]); | ||
| } | ||
| // compare bracket to hash value |
There was a problem hiding this comment.
for this one you'd need to check to see if the character is a key in the object. If so, pop and compare to make sure they match, if not then you can push the current character onto the stack.
Comment on lines
+9
to
+14
| if (this.rear === (this.size() - 1)) { | ||
| throw new Error ('queue full'); | ||
| } else { | ||
| this.rear++; | ||
| } | ||
| this.store[this.rear] = element; |
There was a problem hiding this comment.
This isn't working as a circular buffer.
Comment on lines
+18
to
+27
| if (this.front === (this.size() - 1)) { | ||
| throw new Error ('queue full'); | ||
| } else { | ||
| this.front++; | ||
| } | ||
|
|
||
| const fifo = this.store[this.front]; | ||
| this.store[this.front] = null; | ||
|
|
||
| return fifo; |
| } | ||
|
|
||
| pop() { | ||
| throw new Error("This method has not been implemented!"); | ||
| let removedItem = this.store.getLast(); | ||
| this.store.delete(removedItem); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time-boxed and didn't finish problems.js. will complete if i get through cs fun