Stacks-queues (Sumitra, Scissors class) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 4, 2021
Comment on lines
+25
to
+39
| if self.size == self.buffer_size: | ||
| raise QueueFullException("Queue if full") | ||
|
|
||
| # condition for empty queue | ||
| elif (self.front == -1): | ||
| self.front = 0 | ||
| self.rear = 0 | ||
| self.store[self.rear] = element | ||
| self.size +=1 | ||
|
|
||
| else: | ||
| # next position of rear | ||
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.store[self.rear] = element | ||
| self.size +=1 |
Comment on lines
+47
to
+62
| if self.size == 0: | ||
| raise QueueEmptyException("Queue is empty") | ||
|
|
||
| data = self.store[self.front] | ||
| self.store[self.front] = None | ||
| self.size -= 1 | ||
|
|
||
| if self.front == self.rear: | ||
| self.front = -1 | ||
| self.rear = -1 | ||
| elif self.front == self.buffer_size-1: | ||
| self.front = 0 | ||
| else: | ||
| self.front +=1 | ||
|
|
||
| return data |
There was a problem hiding this comment.
👍 However this could be simplified with the `self.front = (self.front + 1) % self.buffer_size
Comment on lines
+69
to
+71
| if self.size == 0: | ||
| return None | ||
| return self.store[self.front] |
Comment on lines
+94
to
+110
| elements = [] | ||
|
|
||
| if self.front == -1: | ||
| return str(elements) | ||
|
|
||
| elif self.rear >= self.front: | ||
| for element in range(self.front, self.rear+1): | ||
| elements.append(self.store[element]) | ||
|
|
||
| else: | ||
| for element in range(self.front, self.buffer_size): | ||
| elements.append(self.store[element]) | ||
|
|
||
| for element in range(0, self.rear+1): | ||
| elements.append(self.store[element]) | ||
|
|
||
| return str(elements) |
| @@ -12,7 +12,9 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation