Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15 - Katrina K #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SterlingSunshine
Copy link

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question Answer
What is an ADT? Abstract Data Type
Describe a Stack Last in first out data storage
What are the 5 methods in Stack and what does each do? init - Initializes the stack type; Push - Adds an element on the top of the stack; Pop - Removes the top element from the stack; str - Converts the stack to a printable string
Describe a Queue First in first out data storage
What are the 5 methods in Queue and what does each do? init - Initializes the queue; Enqueue - Adds an element to the end of the queue; Dequeue - Removes the first element in the queue; Front - Returns the element that is currently at the front of the queue; Size - Returns how many elements are currently in the queue; Empty - Returns true for an empty queue and false otherwise; str - Converts the queue into a printable string
What is the difference between implementing something and using something? Implementing something means to design and build the logical steps of an algorithm or data storage type where as using it is to store data and ask for data back from a separately implemented system

OPTIONAL JobSimulation

Question Answer
Did you include a sample run of your code as a comment? No? I'm not sure what this would look like

@SterlingSunshine SterlingSunshine changed the title All tests passing C15 - Katrina K Dec 14, 2021
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done Katrina, you hit the learning goals here. Great work.

Comment on lines +26 to +42

# buffer is full
if self.size == self.buffer_size:
raise QueueFullException

# buffer is empty and new
if self.front == -1:
print("Imma new buffer!")
self.front = 0
self.rear = 1
self.store[self.front] = element
self.size += 1
return

self.store[self.rear] = element
self.rear = (self.rear + 1 ) % self.buffer_size
self.size += 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


self.store[self.rear] = element
self.rear = (self.rear + 1 ) % self.buffer_size
self.size += 1

def dequeue(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

self.front = (self.front + 1) % self.buffer_size
self.size -= 1

return element

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if self.size == 0:
return True

return False

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done

Comment on lines +80 to +83
if self.size == 0:
return True

return False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.size == 0:
return True
return False
return self.size == 0

@@ -12,27 +12,34 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_first(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The Stack class works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants