Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15 - Katrina K #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions stacks_queues/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,39 +23,70 @@ def enqueue(self, element):
In the store are occupied
returns None
"""
pass

# buffer is full
if self.size == self.buffer_size:
raise QueueFullException

# buffer is empty and new
if self.front == -1:
print("Imma new buffer!")
self.front = 0
self.rear = 1
self.store[self.front] = element
self.size += 1
return

self.store[self.rear] = element
self.rear = (self.rear + 1 ) % self.buffer_size
self.size += 1
Comment on lines +26 to +42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


def dequeue(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" Removes and returns an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
"""
pass
# queue empty
if self.size == 0:
raise QueueEmptyException

element = self.store[self.front]
self.front = (self.front + 1) % self.buffer_size
self.size -= 1

return element

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" Returns an element from the front
of the Queue and None if the Queue
is empty. Does not remove anything.
"""
pass
if self.size == 0:
return None

return self.store[self.front]


def size(self):
""" Returns the number of elements in
The Queue
"""
pass
return self.size

def empty(self):
""" Returns True if the Queue is empty
And False otherwise.
"""
pass
if self.size == 0:
return True

return False
Comment on lines +80 to +83

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.size == 0:
return True
return False
return self.size == 0


def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done

""" Returns the Queue in String form like:
[3, 4, 7]
Starting with the front of the Queue and
ending with the rear of the Queue.
"""
pass

return str([self.store[index % self.buffer_size] for index in range(self.front, (self.front + self.size))])
15 changes: 11 additions & 4 deletions stacks_queues/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,34 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_first(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The Stack class works


def pop(self):
""" Removes an element from the top
Of the Stack
returns Value popped
Raises a StackEmptyException if
The Stack is empty.
returns None
"""
pass
if self.store.length() < 1:
raise StackEmptyException

return self.store.remove_first()

def empty(self):
""" Returns True if the Stack is empty
And False otherwise
"""
pass
if self.store.length() < 1:
return True

return False

def __str__(self):
""" Returns the Stack in String form like:
[3, 4, 7]
Starting with the top of the Stack and
ending with the bottom of the Stack.
"""
pass
return str(self.store)
1 change: 1 addition & 0 deletions tests/test_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def test_it_can_create_a_queue(queue):

def test_you_can_add_to_queue(queue):
queue.enqueue(10)
print(str(queue))
assert str(queue) == "[10]"

def test_you_can_add_multiple_items(queue):
Expand Down