Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scissors - Hena #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Scissors - Hena #40

wants to merge 2 commits into from

Conversation

hena-lee
Copy link

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question Answer
What is an ADT?
Describe a Stack
What are the 5 methods in Stack and what does each do?
Describe a Queue
What are the 5 methods in Queue and what does each do?
What is the difference between implementing something and using something?

OPTIONAL JobSimulation

Question Answer
Did you include a sample run of your code as a comment?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Hena, you hit the learning goals here. I left a few suggestions, but this is overall pretty good.

Comment on lines 20 to 25
def enqueue(self, element):
""" Adds an element to the Queue
Raises a QueueFullException if all elements
In the store are occupied
returns None
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 42 to 47
def dequeue(self):
""" Removes an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
returns None
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

element = self.store[self.front]
self.front = (self.front + 1) % self.buffer_size
self.size -= 1
return element

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍



def size(self):
""" Returns the number of elements in
The Queue
"""
pass
return self.size()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would end up with infinite recursion

Suggested change
return self.size()
return self.size

Comment on lines +76 to +77
if self.size == 0:
return True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.size == 0:
return True
return self.size == 0


def empty(self):
""" Returns True if the Queue is empty
And False otherwise.
"""
pass
if self.size == 0:
return True

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -12,7 +12,7 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_first(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The stack methods work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants