Scissors // Raquel Mena #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_description method"
beccaelenzil
reviewed
Apr 7, 2021
There was a problem hiding this comment.
Wow! Great work on your first OOP project. You've met the learning goals around working with composition, inheritance, working on a project with multiple files, and reading tests. Your code is logical and readable. I've made a few suggestions of small ways you might consider refactoring. Keep up the hard work!
| @@ -0,0 +1,8 @@ | |||
| from .item import Item | |||
|
|
|||
| class Clothing(Item): | |||
Comment on lines
+33
to
+36
| self.remove(my_item) | ||
| friend.add(my_item) | ||
| friend.remove(friends_item) | ||
| self.add(friends_item) |
There was a problem hiding this comment.
great use of add and remove as helper function
Comment on lines
+48
to
+49
| self.swap_items(friend, self.inventory[0], friend.inventory[0]) | ||
| return True |
There was a problem hiding this comment.
Consider moving this outside of the else clause.
Comment on lines
+30
to
+39
| if my_item in self.inventory and friends_item in friend.inventory: | ||
| # friend.add(self.remove(my_item)) | ||
| # self.add(friend.remove(friends_item)) | ||
| self.remove(my_item) | ||
| friend.add(my_item) | ||
| friend.remove(friends_item) | ||
| self.add(friends_item) | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Consider reorganizing like this to deal with the edge case first and move the main logic of the function out from being nested.
Suggested change
| if my_item in self.inventory and friends_item in friend.inventory: | |
| # friend.add(self.remove(my_item)) | |
| # self.add(friend.remove(friends_item)) | |
| self.remove(my_item) | |
| friend.add(my_item) | |
| friend.remove(friends_item) | |
| self.add(friends_item) | |
| return True | |
| else: | |
| return False | |
| if my_item not in self.inventory or friends_item not in friend.inventory: | |
| return False | |
| self.remove(my_item) | |
| friend.add(my_item) | |
| friend.remove(friends_item) | |
| self.add(friends_item) | |
| return True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.