-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scissors - Maria M. #53
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great! Very readable and thorough!
self.remove(my_item) | ||
friend.add(my_item) | ||
friend.remove(their_item) | ||
self.add(their_item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of existing methods!
my_first_item = self.inventory[0] | ||
their_first_item = friend.inventory[0] | ||
|
||
self.swap_items(friend, my_first_item, their_first_item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of the existing method!
|
||
def swap_best_by_category(self, other, my_priority, their_priority): | ||
|
||
my_best_item = self.get_best_by_category(their_priority) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of the existing method!
No description provided.