Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scissors - Maria M. #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

maria-im015
Copy link

No description provided.

Copy link

@jmaddox19 jmaddox19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! Very readable and thorough!

Comment on lines +39 to +42
self.remove(my_item)
friend.add(my_item)
friend.remove(their_item)
self.add(their_item)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of existing methods!

my_first_item = self.inventory[0]
their_first_item = friend.inventory[0]

self.swap_items(friend, my_first_item, their_first_item)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of the existing method!


def swap_best_by_category(self, other, my_priority, their_priority):

my_best_item = self.get_best_by_category(their_priority)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of the existing method!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants