Paper--Andrea Palacios #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 9, 2021
| @@ -0,0 +1,10 @@ | |||
| from swap_meet.item import Item | |||
|
|
|||
| class Clothing(Item): | |||
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| class Item: | |||
|
|
||
| class Vendor: | ||
|
|
||
| def __init__(self, inventory= None): |
| self.inventory = inventory | ||
|
|
||
|
|
||
| def add(self, item): |
| return item | ||
|
|
||
|
|
||
| def remove(self, item): |
Comment on lines
+40
to
+41
| else: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| else: | |
| return False | |
| return False |
| return False | ||
|
|
||
|
|
||
| def swap_first_item(self, other): |
There was a problem hiding this comment.
👍 , just note that you don't need the else:
|
|
||
|
|
||
| def swap_first_item(self, other): | ||
| if len(self.inventory) == 0 or len(other.inventory) == 0: |
There was a problem hiding this comment.
You can simplify this a bit.
Suggested change
| if len(self.inventory) == 0 or len(other.inventory) == 0: | |
| if not self.inventory or not other.inventory: |
| return True | ||
|
|
||
|
|
||
| def get_best_by_category(self, category): |
| #[for item in items_list if item.condition > best_condition_item.condition] | ||
|
|
||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.