Rock - Drew Taylor #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing everything to be true. The skeleton of Wave complete as well
spitsfire
reviewed
Apr 15, 2021
| from swap_meet.item import Item | ||
|
|
||
|
|
||
| class Clothing(Item): |
There was a problem hiding this comment.
👍 perfectly done! this is a great example of inheritance and using the super class
| @@ -0,0 +1,9 @@ | |||
| from swap_meet.item import Item | |||
|
|
|||
| class Decor(Item): | |||
| @@ -0,0 +1,9 @@ | |||
| from swap_meet.item import Item | |||
|
|
|||
| class Electronics(Item): | |||
| @@ -0,0 +1,21 @@ | |||
| class Item: | |||
| def __str__(self): | ||
| return "Hello World!" | ||
|
|
||
| def condition_description(self): |
| else: | ||
| return False | ||
|
|
||
| def get_by_category(self, category): |
|
|
||
| #Wave 3 ***************************** | ||
|
|
||
| def swap_items(self, friend_vendor, my_item, their_item): |
Comment on lines
+41
to
+51
| def swap_first_item(self, friend): | ||
|
|
||
| if len(self.inventory) == 0 or len(friend.inventory) == 0: | ||
| return False | ||
| first_item = self.inventory[0] | ||
| self.remove(self.inventory[0]) | ||
| self.add(friend.inventory[0]) | ||
| friend.remove(friend.inventory[0]) | ||
| friend.add(first_item) | ||
|
|
||
| return True |
There was a problem hiding this comment.
👍 this works perfectly, but I think we are already doing this on lines 30 - 36. So let's try something like this:
Suggested change
| def swap_first_item(self, friend): | |
| if len(self.inventory) == 0 or len(friend.inventory) == 0: | |
| return False | |
| first_item = self.inventory[0] | |
| self.remove(self.inventory[0]) | |
| self.add(friend.inventory[0]) | |
| friend.remove(friend.inventory[0]) | |
| friend.add(first_item) | |
| return True | |
| def swap_first_item(self, friend): | |
| return self.swap_items(friend, self.inventory[0], friend.inventory[0]) |
we have a method that already swaps items, so we should use it!
Comment on lines
+55
to
+63
| def get_best_by_category(self, category): | ||
| highest_condition = 0 | ||
| highest_item = None | ||
| for item in self.inventory: | ||
| if item.category == category: | ||
| if item.condition > highest_condition: | ||
| highest_condition = item.condition | ||
| highest_item = item | ||
| return highest_item |
There was a problem hiding this comment.
👍 this works great! we could also bring in get_by_category method to get all the items of that category then run through them, but your way actually saves you a for loop!
so this is just fine
| return highest_item | ||
|
|
||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
There was a problem hiding this comment.
👍 good job using your other methods to make your code DRY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.