Scissors - Mariela C. #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the respective category
jmaddox19
reviewed
Apr 7, 2021
Comment on lines
+11
to
+18
| if self.condition >= 5: | ||
| return "BRAND NEW - STRAIGHT OUT OF THE BOX" | ||
| elif self.condition >= 4: | ||
| return "Looks Brand New" | ||
| elif self.condition >= 3: | ||
| return "A few imperfections - Nobody's Perfect!" | ||
| elif self.condition >= 1: | ||
| return "Fairly Used, Easy DIY fix" |
|
|
||
|
|
||
| # --------------- Wave 3 -------------- | ||
| def swap_items(self,friend_vendor,my_item,their_item): |
There was a problem hiding this comment.
This all works great! That said, this method would be a good place to make use of the add and remove methods above
| else: | ||
| first_item = self.inventory[0] | ||
| first_friend_item = friend_vendor.inventory[0] | ||
| self.swap_items(friend_vendor,first_item,first_friend_item) |
There was a problem hiding this comment.
Great that the code makes use of swap_items here!
| def get_best_by_category(self, category): | ||
| highest_condition = 0 | ||
| quality_item = None | ||
| matching_category_items = self.get_by_category(category) |
There was a problem hiding this comment.
Great that you used get_by_category here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.