Scissors_Gloria_Villa #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
Apr 8, 2021
Comment on lines
+20
to
+23
| elif self.condition == 1: | ||
| desc = "Might use a glove" | ||
| elif self.condition == 0: | ||
| desc = "Make sure you really want to do this!" |
Comment on lines
+67
to
+73
| self_first_item = self.inventory[0] | ||
| vendor_first_item = vendor.inventory[0] | ||
| self.remove(self_first_item) | ||
| self.add(vendor_first_item) | ||
| vendor.remove(vendor_first_item) | ||
| vendor.add(self_first_item) | ||
| return True |
There was a problem hiding this comment.
This looks a whole lot like the code in the method above! I wonder if there's a way we could make use of that other method here...
| return None | ||
|
|
||
| best_item = None | ||
| for item in self.get_by_category(category): |
There was a problem hiding this comment.
Love that you made use of the existing method here!
Comment on lines
+102
to
+106
| if other.get_by_category(my_priority) == None or self.get_by_category(their_priority)== None: | ||
| return False | ||
|
|
||
| my_trade_to_other = self.get_best_by_category(their_priority) | ||
| their_trade_to_me = other.get_best_by_category(my_priority) |
There was a problem hiding this comment.
One minor optimization here would be to store the results of self.get_best_by_category(their_priority) and other.get_best_by_category(my_priority) in variables.
When you call the methods twice, they need to do all the work twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indents fixed.