Rock- Briyana Haywood #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreyandoy
reviewed
Apr 13, 2021
Comment on lines
+2
to
+7
| class Clothing(Item): | ||
| def __init__(self, condition = 0): | ||
| self.category = "Clothing" | ||
| self.condition = condition | ||
| def __str__(self): | ||
| return "The finest clothing you could wear." |
There was a problem hiding this comment.
To refactor and truly inherit from the Item class, you can use a super() constructor like so:
Suggested change
| class Clothing(Item): | |
| def __init__(self, condition = 0): | |
| self.category = "Clothing" | |
| self.condition = condition | |
| def __str__(self): | |
| return "The finest clothing you could wear." | |
| class Clothing(Item): | |
| def __init__(self, condition = 0): | |
| super().__init__(self, category = "Clothing", condition) | |
| def __str__(self): | |
| return "The finest clothing you could wear." |
There was a problem hiding this comment.
This same logic can also be used for Decor and Electronics.
Comment on lines
+9
to
+23
| def condition_description(self): | ||
| if self.condition == 0: | ||
| return "Poor" | ||
| elif self.condition <= 1: | ||
| return "Fair" | ||
| elif self.condition <= 2: | ||
| return "Gently Used" | ||
| elif self.condition <= 3: | ||
| return "Good Condition" | ||
| elif self.condition <= 4: | ||
| return "Excellent Condition" | ||
| elif self.condition <= 5: | ||
| return "Like Brand New" | ||
| else: | ||
| return "Invalid Number" |
There was a problem hiding this comment.
This is great! It would also be good to check if condition is expected to be an integer.
| for items in list_by_category: | ||
| if items.condition > best_item.condition: | ||
| best_item = items | ||
| return best_item |
Comment on lines
+111
to
+113
| my_category = other.get_best_by_category(my_priority) | ||
| their_category = self.get_best_by_category(their_priority) | ||
| return self.swap_items(other, their_category, my_category) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.