Paper - Katrina K #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Jun 22, 2021
Comment on lines
+20
to
+22
| const randEmoji = () => { | ||
| return emojiSelector[Math.floor(Math.random() * 5)]; | ||
| } |
Comment on lines
+24
to
+28
| const changeTemp = (delta) => { | ||
| state.temp += delta; | ||
| const tempDisplay = document.querySelector("#tempDisplay"); | ||
| tempDisplay.textContent = `${state.temp}`; | ||
| } |
There was a problem hiding this comment.
Great helper function!
How could you add in the text color change here?
Comment on lines
+81
to
+82
| const updateCity = document.getElementById("cityPicker"); | ||
| updateCity.addEventListener("change", cityUpdate); |
There was a problem hiding this comment.
This works, but there are multiple event types that can be used here that result in different behavior. The change event doesn't trigger unless user presses enter, while the input event will trigger every time the user inputs a character (https://www.w3schools.com/jsref/event_oninput.asp).
|
Great work on this project! Part of Wave 2 is missing, but there are some additional enhancements. This project is green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.