Paper-Manu Ponce #67
Open
Paper-Manu Ponce #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jun 25, 2021
| temperature += 1; | ||
| tempValue.innerHTML = temperature; | ||
| if (temperature >= 80) { | ||
| tempValue.className = "red"; |
There was a problem hiding this comment.
You should avoid class names like yellow and instead use something like warm or hot.
A class name should describe what the thing means, not its effect.
The example will be updated to reflect this for next cohort.
| let skyElement = document.getElementById("sky") | ||
|
|
||
| let increaseTempControl = document.getElementById("increaseTempControl"); | ||
| increaseTempControl.addEventListener("click", function () { |
There was a problem hiding this comment.
You repeat a lot of logic between increaseTempControl and decreaseTempControl a helper function could DRY up your code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.