Rock -Brittany #68
Open
Rock -Brittany #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jul 1, 2021
| <div class="card"> | ||
| <h3>City Name</h3> | ||
| <!--City Name Form--> | ||
| <form class="form" action="/action_page.php"> |
There was a problem hiding this comment.
in this instance we don't need an action attribute. This is necessary for more traditional websites to trigegr a request to a backend
Suggested change
| <form class="form" action="/action_page.php"> | |
| <form class="form"> |
Comment on lines
+13
to
+17
| <div class="header"> | ||
| <h1>Weather Report</h1> | ||
| <h2>For the loveley city of</h2> | ||
| <p class="city-name">🌊 🌙 Oceanville🌙🌊</p> | ||
| </div> |
There was a problem hiding this comment.
don't forget to use semantic html, like header, section, main rather than div
| <button id="upButton" class="temp-button">🔼</button> | ||
| <button id="downButton" class="temp-button">🔽</button> | ||
| </div> | ||
| <div id="value" class="temp-value">32</div> |
There was a problem hiding this comment.
let's use something other than a div here. a div is for dividing similar html elements together. this should more likely be a heading like h3 or a p elements. these are for text.
Comment on lines
+34
to
+36
| <div class="card"> | ||
| <h3>Sky</h3> | ||
| </div> |
There was a problem hiding this comment.
not everything needs a parent element. an h3 can stand on its own!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.