Pine-Roslyn M. #74
Open
Pine-Roslyn M. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Dec 15, 2021
| <section class="main-container"> | ||
| <section class="controls"> | ||
| <div class="subcontrols">Temperature | ||
| <div><span id="down">🧊</span><span class="tempcol" id="temp"> 70 </span><span id="up">🔥</span></div></div> |
There was a problem hiding this comment.
To add spacing between the span tags, look at padding-left and padding-right.
| const skyscene = document.getElementById('gardenactivity') | ||
| const garden = document.getElementsByClassName('garden') | ||
|
|
||
| const changeTempColor = () => { |
Comment on lines
+63
to
+73
| sky.addEventListener('change', changeSky) | ||
|
|
||
| form.addEventListener('input', changeCity) | ||
|
|
||
| up.addEventListener('click', ()=>{ | ||
| state.tempCount += 1; | ||
| temp.textContent = `${state.tempCount}`; | ||
| changeTempColor(); | ||
| }) | ||
|
|
||
| down.addEventListener('click', () => { |
There was a problem hiding this comment.
I recommend wrapping all of the addEventListener calls in a registerEventHandler type function, and then set that up to run when "DOMContentLoaded" event triggers.
| @@ -0,0 +1,79 @@ | |||
| const up = document.getElementById("up") | |||
There was a problem hiding this comment.
This setup works, but if the script tag was moved from the bottom of the web page to the top, they would stop working, because they would attempt to run before the html loads. I would recommend grabbing these elements in the functions that need them, rather than doing it all at the same time here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.