Cedar - Jessica Carnes - Weather Report #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Dec 16, 2021
| </header> | ||
| <main> | ||
| <section id=temperature class="small_box tempBox"> | ||
| <h2 id=tempTitle>TEMPERATURE</h2> |
There was a problem hiding this comment.
You skipped directly to a <h2> without having an <h1>. Your heading tags should be able to be used to create a table of contents so it's important not to skip levels.
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Weather Report</title> | ||
| <link href="../styles/index.css" rel="stylesheet" /> |
There was a problem hiding this comment.
Your imports appear to be off by a folder:
Suggested change
| <link href="../styles/index.css" rel="stylesheet" /> | |
| <link href="./styles/index.css" rel="stylesheet" /> |
Comment on lines
+51
to
+52
| <script | ||
| src="../scripts/index.js"> |
There was a problem hiding this comment.
Suggested change
| <script | |
| src="../scripts/index.js"> | |
| <script | |
| src="./scripts/index.js"> |
Comment on lines
+78
to
+82
| /* grid-template-areas: | ||
| ". . . ." | ||
| "tempTitle tempTitle tempTitle tempTitle" | ||
| ". tempButtons . tempValue ." | ||
| ". tempButtons . tempValue ."; */ |
There was a problem hiding this comment.
Style: It's a best practice to remove commented out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.