Cedar - Rebeca Muniz #76
Conversation
|
|
||
| <section class = "temperature-side-container" action="#"> | ||
| <h3> Temperature </h3> | ||
| <p id = "temperature-value"> 76 </p> |
There was a problem hiding this comment.
Minor note: it is a convention not to include spaces between a properties and it's value.
| <p id = "temperature-value"> 76 </p> | |
| <p id="temperature-value"> 76 </p> |
| <title>Document</title> | ||
| <link rel="stylesheet" href= "styles/index.css"/> | ||
| </head> | ||
| <body class="parent-side-container"> |
There was a problem hiding this comment.
Nice work writing clear, semantic HTML!
|
|
||
| <section class = "temperature-side-container" action="#"> | ||
| <h3> Temperature </h3> | ||
| <p id = "temperature-value"> 76 </p> |
There was a problem hiding this comment.
Consider initializing with class name 'orange' so when the page first loads the 76 is orange
| } | ||
|
|
||
| const changeTempTextColor = () => { | ||
| if(state.tempCount >= 80) { |
There was a problem hiding this comment.
A chained conditional if\else if\else if would make this code a bit more efficient. Also, minor note, if orangize it as temp <= 49 / else if temp <= 59 ... we do not need the compound conditional.
| snowy: "🌨❄️🌨🌨❄️❄️🌨❄️🌨❄️❄️🌨", | ||
| } | ||
|
|
||
| const state = { |
| cityInput = cityInput.defaultValue | ||
| } | ||
|
|
||
| const registerEventHandlers = (event) => { |
There was a problem hiding this comment.
Great work organizing this event listeners in the registerEventHandlers function. You might consider refactoring grabbing the corresponding elements that are declared as variables at the top of the script here instead.
No description provided.