Melinda H. Pine Class #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Dec 16, 2021
|
|
||
| if (temperature >=80) { | ||
| color = 'red' | ||
| } else if (70<=temperature<=79) { |
There was a problem hiding this comment.
I know this section isn't running right now, but I wanted to point out a syntax issue. This type of conditional has to be formatted like this:
Suggested change
| } else if (70<=temperature<=79) { | |
| } else if (70<=temperature && temperature<=79) { |
the && is equivalent to and in python.
| }; | ||
| console.log(skyValue) | ||
| } | ||
| setTypeOfWeather() |
There was a problem hiding this comment.
I recommend moving this call inside the 'registerEventHandlers' function, so that it's guaranteed to run after the html is loaded.
| </section> | ||
|
|
||
| <section id="Sky-Container"> | ||
| <h3> Sky </h3> |
There was a problem hiding this comment.
This section is a sibling of the temperature section, so the h-tag level would be the same.
Suggested change
| <h3> Sky </h3> | |
| <h2> Sky </h2> |
| </section> | ||
|
|
||
| <section id="Weather-Garden"> | ||
| <h4> Weather Garden</h4> |
There was a problem hiding this comment.
Suggested change
| <h4> Weather Garden</h4> | |
| <h2> Weather Garden</h2> |
|
|
||
|
|
||
| <section id="City-Name"> | ||
| <h3> City Name </h3> |
There was a problem hiding this comment.
Suggested change
| <h3> City Name </h3> | |
| <h2> City Name </h2> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.