Skip the rlimit_ctrl_c and rlimit_forground tests if you're not using tox #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzbang
requested changes
Jun 30, 2023
|
@enzbang This is already done. |
|
@leocardao you have not done what I suggested: using pytest.mark.skipif instead of having an early return in the function code. Currently your patch makes the function pass even if there is a bug. Returning SKIP is much clearer. |
… tox. Some tests require ptyprocess to run, but ptyprocess is not included by default with e3, so they always fail in a production environment (without internet).
leocardao
force-pushed
the
mr/cardao/fix-rlimit-test
branch
from
53cb3bd to
f89f520
Compare
|
This pull request is obsolete, as ptyprocess is now referenced in setup.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests require ptyprocess to run, but ptyprocess is not included by default with e3, so they always fail in a production environment (without internet).