Fix pytest error #712
Merged
Fix pytest error #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzbang
reviewed
Apr 4, 2024
When pytest is used with xdist and junitxml, tests are not run in the main thread. In addition, signals can only be used in the main thread. This results in the failure of some tests that attempt to define a signal handler. The signal handler causing the error is not tested, so we simply disable the handler if the current thread is not the main thread.
leocardao
force-pushed
the
mr/cardao/fix-pytest-error
branch
from
ead8b8a
to
77137d1
Compare
grouigrokon
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pytest is used with xdist and junitxml, tests are not run in the main thread. In addition, signals can only be used in the main thread.
This results in the failure of some tests that attempt to define a signal handler.
The signal handler causing the error is not tested, so we simply disable the handler if the current thread is not the main thread.