Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duality Serializers should support updating an existing instance when loading #877

Open
ilexp opened this issue Sep 5, 2020 · 0 comments
Labels
Core Area: Duality runtime or launcher Feature It doesn't exist yet, but I want it
Milestone

Comments

@ilexp
Copy link
Member

ilexp commented Sep 5, 2020

Summary

Right now, Duality serializers always return a new instance of a deserialized / loaded object. This should be extended to allow updating an existing instance.

Analysis

  • Deep instance re-use would be the ideal case, but will need further investigation.
  • Shallow instance re-use for only the provided top-level object could be some first iteration middle ground, but should only be done if significantly easier than the deep case, depending on investigation results.
  • A workaround in the mean time could be to deserialize into a new temp instance and use the cloning system to copy all values over to the existing instance.
@ilexp ilexp added Feature It doesn't exist yet, but I want it Core Area: Duality runtime or launcher labels Sep 5, 2020
@ilexp ilexp added this to the General milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Area: Duality runtime or launcher Feature It doesn't exist yet, but I want it
Development

No branches or pull requests

1 participant