New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add semantic groups for services #400

Open

jellizaveta wants to merge 68 commits into main from feature/add_semantic_service_groups

+4,111 −191

Contributor

jellizaveta commented Nov 30, 2023

Added semantic group for each service in yml files.
From all groups in yml files a single object - groups is collected in services.json
Added i18_n translation file for groups, which collects translations for service groups from the locale folder and groups them by id.
Related issue: #382

jellizaveta added 13 commits

November 14, 2023 21:08


          changed the check for removed services

0c45df2


          Added support for groups in services

5cad72f


          re-wrote the structure

8765fb0


          restructured the script

8f78df7


          restructured the script

cea11aa


          added base locale

0e0002d


          localization development


          localization development

8015d72


          added localizations to the services general build

764c13d


          added comments, fixed the variable names

c20472e


          fixed the variable names

7d86c4f


          updated readme.md

deccab3


          linter

2724dde

jellizaveta marked this pull request as draft

November 30, 2023 17:26

jellizaveta added 2 commits

November 30, 2023 20:33


          Merge branch 'main' into feature/add_semantic_service_groups


          merged it with the main branch, added a check for empty groups

jellizaveta changed the title ~~Add semantic groups for services~~ [WIP] add semantic groups for services


          added a check for empty groups

3a4bcd2

jellizaveta marked this pull request as ready for review

November 30, 2023 18:19

jellizaveta requested review from Alex-302 and slavaleleka

November 30, 2023 18:19

jellizaveta changed the title ~~[WIP] add semantic groups for services~~ add semantic groups for services

slavaleleka reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

slavaleleka reviewed

View reviewed changes

locales/en/services.json Outdated Show resolved Hide resolved

slavaleleka reviewed

View reviewed changes

locales/en/services.json Outdated Show resolved Hide resolved

slavaleleka reviewed

View reviewed changes

locales/en/services.json Outdated Show resolved Hide resolved

slavaleleka reviewed

View reviewed changes

index.js Outdated Show resolved Hide resolved

jellizaveta changed the title ~~add semantic groups for services~~ [WIP] add semantic groups for services

jellizaveta added 2 commits

December 13, 2023 19:34


          Merge branch 'main' into feature/add_semantic_service_groups

699ef64


          merge main

1a271cd

jellizaveta added 9 commits

January 30, 2024 12:23


          created typedef ObjectWithID

a035551


          updated the sort function, fixed typedef

5fefeca


          Fixed typedefs

144d10d


          Fixed jsDoc


          Fixed sorting function

20732b2


          added zod

f4e93f6


          added zod validation

3c9bb9b


          added typedefs to add-localizations script

999c5f2


          Added typedefs and zod validation

94476e4

scripthunter7 reviewed

View reviewed changes

scripts/services/zod-schemas.js Outdated Show resolved Hide resolved


          added comments and examples for validation schemes

jellizaveta requested review from slavaleleka and scripthunter7

February 2, 2024 15:09

Contributor Author

jellizaveta commented Feb 2, 2024

@Alex-302 @Sergey-Lyapin Hi! Could you please check

jellizaveta requested a review from Sergey-Lyapin

February 2, 2024 15:35

Alex-302 reviewed

View reviewed changes

services/mail_ru.yml Show resolved Hide resolved

services/pinterest.yml Outdated Show resolved Hide resolved

services/claro.yml Outdated Show resolved Hide resolved

services/wechat.yml Outdated Show resolved Hide resolved

services/youtube.yml Outdated Show resolved Hide resolved

services/gog.yml Outdated Show resolved Hide resolved

services/kik.yml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

services/cloudflare.yml Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

jellizaveta and others added 12 commits

February 2, 2024 21:09


          Update services/kik.yml

6d48a1c

Co-authored-by: Alex <alex302@adguard.com>


          Update services/gog.yml

f470464

Co-authored-by: Alex <alex302@adguard.com>


          Update services/youtube.yml

4e2d48a

Co-authored-by: Alex <alex302@adguard.com>


          Update services/wechat.yml

64a40a0

Co-authored-by: Alex <alex302@adguard.com>


          Update services/claro.yml

e7c4b33

Co-authored-by: Alex <alex302@adguard.com>


          Update services/pinterest.yml

bfb5d3e

Co-authored-by: Alex <alex302@adguard.com>


          Update services/skype.yml

7c2c2d7

Co-authored-by: Alex <alex302@adguard.com>


          Update services/kakaotalk.yml

b6b766c

Co-authored-by: Alex <alex302@adguard.com>


          Fixed the groups and group descriptions

8a57982


          Removed types that are already described in the code

9cc81e7


          Added empty line in files

76b712c


          removed unused vars

b068828

jellizaveta requested a review from Alex-302

February 5, 2024 14:49

Contributor

slavaleleka commented Feb 6, 2024

add ability to update the new base strings by locales:upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet