Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta2: Different tasks from Custom product EAV in GraphQL epic (LYNX-52) #151

Merged
merged 23 commits into from
Jul 27, 2023
Merged

Beta2: Different tasks from Custom product EAV in GraphQL epic (LYNX-52) #151

merged 23 commits into from
Jul 27, 2023

Conversation

loginesta
Copy link
Contributor

@loginesta loginesta commented May 29, 2023 •
edited
Loading

Purpose of this pull request

This pull request (PR) covers documentation for the following tasks:

Affected pages

  • src/pages/graphql/schema/attributes/queries/attributes-form.md
  • src/pages/graphql/schema/attributes/queries/attributes-list.md
  • src/pages/graphql/schema/attributes/queries/custom-attribute-metadata-v2.md
  • src/pages/graphql/schema/customer/queries/customer.md
  • src/pages/graphql/schema/cart/mutations/set-shipping-address.md
  • src/pages/graphql/schema/cart/mutations/set-billing-address.md
  • src/pages/_includes/graphql/attribute-value-interface.md
  • src/pages/_includes/graphql/cart-address-input-24.md
  • src/pages/_includes/graphql/customer-output-24.md
  • src/pages/_includes/graphql/return.md

Links to Magento Open Source code

@loginesta loginesta marked this pull request as ready for review May 29, 2023 11:05
@jeff-matthews jeff-matthews added internal Differentiates work between community and Adobe staff major-update Significant updates to content labels May 30, 2023
jeff-matthews
jeff-matthews reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keharper, after you review/approve/merge, I can tag with 2.4.7-beta notes/differentiated code blocks in #149.

@keharper
Copy link
Contributor

@loginesta Since we're so close to the beta1 release date, I have to ask whether this functionality will be part of beta1.

@loginesta
Copy link
Contributor Author

you can find these changes here:
https://github.com/magento-commerce/magento2ee/pull/3577

@jeff-matthews
Copy link
Contributor

According to the internal Engineering wiki for the 2.4.7-beta1 release, the cutoff date for PRs for 2.4.7-beta1 was 5/12 and we've now entered the stabilization period. That indicates that this won't make it in time for 2.4.7-beta1 and we should hold it until we're ready to start merging doc PRs for 2.4.7-beta2. I expect that to be after 2.4.7-beta1 GA (6/13).

@loginesta, if any of that is incorrect, please let us know.

@keharper keharper changed the title LYNX-104: Rma GraphQL ReturnItemAttributeMetadata implementation of CustomAttributeMetadataInterface Beta2: LYNX-104: Rma GraphQL ReturnItemAttributeMetadata implementation of CustomAttributeMetadataInterface May 31, 2023
keharper
keharper previously approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but waiting until beta1 ships to merge

@jeff-matthews jeff-matthews marked this pull request as draft May 31, 2023 14:46
svera
svera reviewed Jul 18, 2023
View reviewed changes
src/pages/_includes/graphql/customer-output-24.md
@@ -5,7 +5,7 @@ Attribute | Data Type | Description
`compare_list` | CompareList | The contents of the customer's comparison list
`created_at` | String | Timestamp indicating when the account was created
`custom_attributes` | [CustomerAddressAttribute](#customeraddress-attributes) | Deprecated. Use `custom_attributesV2` instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link here goes to customer address attributes, it should link to customer attributes instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the link goes nowhere since this doesn't not exist on the page which you currently are

@loginesta loginesta changed the title Beta2: LYNX-104: Rma GraphQL ReturnItemAttributeMetadata implementation of CustomAttributeMetadataInterface Beta2: Different tasks from Custom product EAV in GraphQL epic (LYNX-52) Jul 19, 2023
@keharper keharper self-requested a review July 24, 2023 15:16
@loginesta loginesta marked this pull request as ready for review July 25, 2023 16:29
keharper
keharper reviewed Jul 26, 2023
View reviewed changes
src/pages/_includes/graphql/cart-address-input-24.md Outdated Show resolved Hide resolved
src/pages/_includes/graphql/return.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/attributes/queries/attributes-form.md Show resolved Hide resolved
src/pages/graphql/schema/attributes/queries/attributes-list.md Show resolved Hide resolved
src/pages/graphql/schema/attributes/queries/custom-attribute-metadata-v2.md Show resolved Hide resolved
src/pages/graphql/schema/attributes/queries/custom-attribute-metadata-v2.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/products/interfaces/attributes.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/products/interfaces/attributes.md Outdated Show resolved Hide resolved
@keharper keharper dismissed their stale review July 26, 2023 21:22

I reviewed too early

@keharper keharper merged commit d58aea6 into AdobeDocs:2.4.7-develop Jul 27, 2023
2 checks passed
@loginesta loginesta deleted the LYNX-104 branch July 28, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svera svera svera left review comments

@jeff-matthews jeff-matthews jeff-matthews left review comments

@keharper keharper keharper approved these changes

Assignees

@keharper keharper

Labels
2.4.7 internal Differentiates work between community and Adobe staff major-update Significant updates to content
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loginesta @keharper @jeff-matthews @svera @bl4de