Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update workflows with a build step #264

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix and update workflows with a build step #264

merged 2 commits into from
Dec 13, 2023

Conversation

dshevtsov
Copy link
Contributor

@dshevtsov dshevtsov commented Dec 13, 2023 •
edited
Loading

Purpose of this pull request

This pull request (PR) fixes and updates the stage, publish, github-pages, and index workflows.

  • Use actions/setup-node instead of borales/actions-yarn
  • Upgrade actions/cache to 3.3.2
  • Move the node version to .nvrmc to be able to use it locally too.
  • Upgrade node to the latest minor version of v16 (16.20)
  • Move NODE_OPTIONS to the scripts to be able to use it locally too

Internal ref: COMDOX-866

Testing

Staging
Pages
Indexing

@dshevtsov dshevtsov self-assigned this Dec 13, 2023
@dshevtsov dshevtsov marked this pull request as ready for review December 13, 2023 21:08
@jeff-matthews jeff-matthews added the internal Differentiates work between community and Adobe staff label Dec 13, 2023
@dshevtsov dshevtsov merged commit dca1338 into main Dec 13, 2023
23 checks passed
@dshevtsov dshevtsov deleted the ds_fix-workflows branch December 13, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-matthews jeff-matthews jeff-matthews approved these changes

@keharper keharper Awaiting requested review from keharper

Assignees

@dshevtsov dshevtsov

Labels
internal Differentiates work between community and Adobe staff maintenance
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshevtsov @jeff-matthews