Update all services #1069
Open
Update all services #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
02de1f9
to
5844573
Compare
jillingk
reviewed
Oct 9, 2024
| @@ -116,7 +116,7 @@ protected AccountHolder() { } | |||
| /// Gets or Sets ContactDetails | |||
| /// </summary> | |||
| [DataMember(Name = "contactDetails", EmitDefaultValue = false)] | |||
| [Obsolete] | |||
| [Obsolete("Deprecated since Configuration API v - ")] | |||
There was a problem hiding this comment.
@Kwok-he-Chu If there's no deprecated version / message maybe we should format this differently? Alternatively we can try to enforce this annotation on main if we think this is crucial enough
There was a problem hiding this comment.
Good catch. I have turned this into [Obsolete("")] for now (see PR), we'll enforce the specs to have the messages added from here on out. Fix the problem at root-level*
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
5844573
to
9e503ee
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI spec or templates produced changes on 09-10-2024 by commit.