Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismiss dialog on hot reload #198

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

dismiss dialog on hot reload #198

wants to merge 1 commit into from

Conversation

pinpong
Copy link
Contributor

@pinpong pinpong commented Apr 26, 2023

Improved developer experience by dismissing the pending dialog fragment on hot reload.

How to proof:

  1. Open the example app and open e.g. klarna
  2. close the webview
  3. hot reload
  4. the dialog is no closable because the js bridge was destroyed

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@descorp
Copy link
Contributor

descorp commented May 5, 2023

Hey @pinpong

Thanks for contribution 💚

Same as #201:
This is a nice addition from a development point of view, however, need to do more testing to make sure this can't mess up with Payments flow state in some way 🤔

@descorp descorp added the require verification Extra attention is needed label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
require verification Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinpong @descorp