Skip to content

Commit

Permalink
minor changes for google batch plugin (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
mpvgithub authored Nov 21, 2023
1 parent 15e15b6 commit cdbac38
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 16 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Changed

- Changed the default value for `project_id` & `prefix`

### Added

- Added a variable to fetch the Json key path to connect to google provider
- Added credentials attribute to google provider section via JSON key path

## [0.11.0] - 2023-09-21

### Authors
Expand Down
1 change: 1 addition & 0 deletions covalent_gcpbatch_plugin/assets/infra/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ terraform {
provider google {
project = var.project_id
region = "us-east1"
credentials = file(var.key_path)
}

provider docker {
Expand Down
37 changes: 21 additions & 16 deletions covalent_gcpbatch_plugin/assets/infra/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,37 +15,42 @@
# limitations under the License.


variable project_id {
variable "project_id" {
type = string
default = "aq-gcp-batch-test-10011"
default = "covalenttesting"
}

variable access_token {
type = string
default = ""
sensitive = true
variable "access_token" {
type = string
default = ""
sensitive = true
description = "Google cloud access token for authenticating to the artifact registry"
}

variable context {
type = string
variable "context" {
type = string
description = "Path to the build context. Defaults to the root directory up three levels"
default = "../../.."
default = "../../.."
}

variable prerelease {
type = string
variable "prerelease" {
type = string
description = "Specify if the latest pre-release version of Covalent is to be installed when building the docker container"
default = ""
default = ""
}

variable covalent_package_version {
type = string
variable "covalent_package_version" {
type = string
description = "Covalent version to be installed in the container"
default = "covalent"
}

variable "prefix" {
type = string
default = "covalent"
}

variable prefix {
variable "key_path"{
type = string
default = "venkat"
description = "JSON file containing the credentials to connect to google provider"
}

0 comments on commit cdbac38

Please sign in to comment.