Skip to content

Commit

Permalink
fix(scripts): Update gen-upgrade-proposal.sh to take a target tag arg…
Browse files Browse the repository at this point in the history
…ument (#9337)

Fixes #9335

## Description

If a non-empty argument is present, it is used as the git ref defining
the upgrade target. Otherwise, we fall back on HEAD.

### Security Considerations

None known.

### Scaling Considerations

n/a

### Documentation Considerations

The new pattern should be used in future community.agoric.com posts.

### Testing Considerations

None, but the desired approach has already been used to craft the
mainnet proposal for agoric-upgrade-15.

### Upgrade Considerations

This will allow starting from a checkout of the previous tag, which in
general is correct for crafting proposals to be understood by the
corresponding software.
  • Loading branch information
mergify[bot] authored May 9, 2024
2 parents 1d3807b + 9171bc5 commit a8e4f51
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion scripts/gen-upgrade-proposal.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ https://github.com/agoric-labs/cosmos-sdk/tree/Agoric/cosmovisor#readme
------------------------------------------------------------------------
EOF

COMMIT_ID=$(git rev-parse HEAD)
UPGRADE_TO="${1:-HEAD}"
COMMIT_ID=$(git rev-parse "$UPGRADE_TO")
ZIP_URL="https://github.com/Agoric/agoric-sdk/archive/${COMMIT_ID}.zip"

echo "Verifying archive is at $ZIP_URL..." 1>&2
Expand Down

0 comments on commit a8e4f51

Please sign in to comment.