adopt eslint-env directive (#8702)

## Description

Make our `lint-fix` script use report-unused-disable-directives and run that to remove them. (This requires `yarn format` after because for some reason it puts spaces in front of the Jessie directive.)

Replace many `global` directives with `eslint-env node`. I think those all are to be run in Node. If some are to be run under XS, maybe we should contribute an eslint-env for it: https://eslint.org/docs/latest/use/configure/language-options

### Security Considerations

Arguably reduces visibility of ambient authority. For that I created a script that interested parties can use any time to report on it.

### Scaling Considerations

none

### Documentation Considerations

none

### Testing Considerations

nothing special

### Upgrade Considerations

n/a

golang/cosmos/index.cjs

@@ -1,2 +1,2 @@
-/* global module require */
+/* eslint-env node */
 module.exports = require('bindings')('agcosmosdaemon.node');

packages/SwingSet/src/controller/initializeSwingset.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import fs from 'fs';
 import path from 'path';
 

packages/SwingSet/test/worker-protocol.test.js

@@ -1,4 +1,4 @@
-/* global Buffer */
+/* eslint-env node */
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/agoric-cli/scripts/get-sdk-package-names.js

@@ -1,5 +1,5 @@
 #! /usr/bin/env node
-/* global process, Buffer */
+/* eslint-env node */
 import { spawn } from 'child_process';
 import { basename } from 'path';
 

packages/agoric-cli/src/anylogger-agoric.js

@@ -1,3 +1,4 @@
+/* eslint-env node */
 import {
   getEnvironmentOption,
   getEnvironmentOptionsList,

packages/agoric-cli/src/bin-agops.js

@@ -1,9 +1,8 @@
 #!/usr/bin/env node
+/* eslint-env node */
 // @ts-check
 // @jessie-check
 
-/* global fetch, setTimeout */
-
 import '@endo/init/pre.js';
 
 import '@endo/init';

packages/agoric-cli/src/commands/oracle.js

@@ -1,14 +1,15 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global fetch, setTimeout, process */
+/* eslint-env node */
+import { Offers } from '@agoric/inter-protocol/src/clientSupport.js';
+import { oracleBrandFeedName } from '@agoric/inter-protocol/src/proposals/utils.js';
 import { Fail } from '@endo/errors';
 import { Nat } from '@endo/nat';
-import { Offers } from '@agoric/inter-protocol/src/clientSupport.js';
-import { Command } from 'commander';
 import * as cp from 'child_process';
+import { Command } from 'commander';
 import { inspect } from 'util';
-import { oracleBrandFeedName } from '@agoric/inter-protocol/src/proposals/utils.js';
 import { normalizeAddressWithOptions } from '../lib/chain.js';
+import { bigintReplacer } from '../lib/format.js';
 import { getNetworkConfig, makeRpcUtils, storageHelper } from '../lib/rpc.js';
 import {
   getCurrent,
@@ -17,7 +18,6 @@ import {
   sendAction,
   sendHint,
 } from '../lib/wallet.js';
-import { bigintReplacer } from '../lib/format.js';
 
 /** @import {PriceAuthority, PriceDescription, PriceQuote, PriceQuoteValue, PriceQuery,} from '@agoric/zoe/tools/types.js'; */
 

packages/agoric-cli/src/commands/perf.js

@@ -1,6 +1,6 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global process */
+/* eslint-env node */
 import {
   iterateEach,
   makeCastingSpec,

packages/agoric-cli/src/commands/psm.js

@@ -1,6 +1,6 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global fetch, process */
+/* eslint-env node */
 import { Command } from 'commander';
 import { Offers } from '@agoric/inter-protocol/src/clientSupport.js';
 import { asPercent } from '../lib/format.js';

packages/agoric-cli/src/commands/reserve.js

@@ -1,6 +1,6 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global fetch, process */
+/* eslint-env node */
 import { Offers } from '@agoric/inter-protocol/src/clientSupport.js';
 import { Command } from 'commander';
 import { makeRpcUtils } from '../lib/rpc.js';

packages/agoric-cli/src/commands/test-upgrade.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 import { Fail } from '@endo/errors';
 import { CommanderError } from 'commander';
 import { normalizeAddressWithOptions } from '../lib/chain.js';

packages/agoric-cli/src/commands/vaults.js

@@ -1,6 +1,6 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global fetch, process */
+/* eslint-env node */
 import { Command } from 'commander';
 import {
   lookupOfferIdForVault,

packages/agoric-cli/src/commands/wallet.js

@@ -1,6 +1,6 @@
 // @ts-check
 /* eslint-disable func-names */
-/* global fetch, process */
+/* eslint-env node */
 import {
   iterateLatest,
   makeCastingSpec,

packages/agoric-cli/src/deploy.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process setTimeout setInterval clearInterval */
+/* eslint-env node */
 
 import { X } from '@endo/errors';
 import { makePromiseKit } from '@endo/promise-kit';

packages/agoric-cli/src/entrypoint.js

@@ -1,8 +1,7 @@
 #!/usr/bin/env node
+/* eslint-env node */
 // @jessie-check
 
-/* global process */
-
 import '@endo/init/pre.js';
 import 'esm';
 import '@endo/init/legacy.js';

packages/agoric-cli/src/helpers.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 // @ts-check
 
 /** @import { ChildProcess } from 'child_process' */

packages/agoric-cli/src/install.js

@@ -1,4 +1,4 @@
-/* global process Buffer */
+/* eslint-env node */
 import path from 'path';
 import chalk from 'chalk';
 import { makePspawn } from './helpers.js';

packages/agoric-cli/src/lib/bundles.js

@@ -1,6 +1,5 @@
 // @ts-check
-
-/* global Buffer */
+/* eslint-env node */
 
 import assert from 'node:assert/strict';
 import fs from 'node:fs';

packages/agoric-cli/src/lib/chain.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 import { normalizeBech32 } from '@cosmjs/encoding';
 import { execFileSync as execFileSyncAmbient } from 'child_process';
 

packages/agoric-cli/src/lib/rpc.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global Buffer, fetch, process */
+/* eslint-env node */
 
 import { NonNullish } from '@agoric/internal';
 import {

packages/agoric-cli/src/lib/wallet.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 
 import { Fail } from '@endo/errors';
 import { iterateReverse } from '@agoric/casting';

packages/agoric-cli/src/main-publish.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 // @ts-check
 
 import path from 'path';

packages/agoric-cli/src/main.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import { Command } from 'commander';
 import path from 'path';
 import url from 'url';

packages/agoric-cli/src/open.js

@@ -1,4 +1,4 @@
-/* global process setInterval clearInterval */
+/* eslint-env node */
 import opener from 'opener';
 import { assert, X } from '@endo/errors';
 import { getAccessToken } from '@agoric/access-token';

packages/agoric-cli/src/scripts.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 import bundleSource from '@endo/bundle-source';
 import { E } from '@endo/captp';
 import { search as readContainingPackageDescriptor } from '@endo/compartment-mapper';

packages/agoric-cli/src/start.js

@@ -1,4 +1,4 @@
-/* global process setTimeout */
+/* eslint-env node */
 import chalk from 'chalk';
 import { createHash } from 'crypto';
 import path from 'path';

packages/agoric-cli/test/inter-cli.test.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global Buffer */
+/* eslint-env node */
 import '@endo/init';
 import test from 'ava';
 import { createCommand, CommanderError } from 'commander';

packages/agoric-cli/test/upgrade-contract/propose-buggy-contract.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 
 import { makeHelpers } from '@agoric/deploy-script-support';
 

packages/agoric-cli/test/upgrade-contract/propose-upgrade-contract.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 
 import { makeHelpers } from '@agoric/deploy-script-support';
 

packages/agoric-cli/tools/getting-started.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process setTimeout setInterval clearInterval Buffer */
+/* eslint-env node */
 
 import fs from 'fs';
 import path from 'path';

packages/boot/tools/supports.ts

@@ -1,5 +1,5 @@
 /* eslint-disable jsdoc/require-param, @jessie.js/safe-await-separator */
-/* global process */
+/* eslint-env node */
 
 import childProcessAmbient from 'child_process';
 import { promises as fsAmbientPromises } from 'fs';

packages/builders/scripts/inter-protocol/add-collateral-core.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import { makeHelpers } from '@agoric/deploy-script-support';
 
 import { getManifestForAddAssetToVault } from '@agoric/inter-protocol/src/proposals/addAssetToVault.js';

packages/builders/scripts/inter-protocol/init-core.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 /**
  * @file can be run with `agoric deploy` after a chain is running (depends on
  *   chain state) Only works with "local" chain and not sim-chain b/c it needs

packages/builders/scripts/inter-protocol/invite-committee-core.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import { makeHelpers } from '@agoric/deploy-script-support';
 
 import { getManifestForInviteCommittee } from '@agoric/inter-protocol/src/proposals/committee-proposal.js';

packages/builders/scripts/inter-protocol/price-feed-core.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import { makeHelpers } from '@agoric/deploy-script-support';
 
 export const DEFAULT_CONTRACT_TERMS = {

packages/cosmic-swingset/check-validator.cjs

@@ -1,7 +1,7 @@
 #! /usr/bin/env node
+/* eslint-env node */
 // @jessie-check
 
-/* global process require Buffer */
 // check-validator - Find if there is a validator that matches the current ag-chain-cosmos
 // Michael FIG <mfig@agoric.com>, 2021-06-25
 const oper = process.argv[2];

packages/cosmic-swingset/scripts/clean-core-eval.js

@@ -1,6 +1,6 @@
 #! /usr/bin/env node
 /* global globalThis */
-
+/* eslint-env node */
 import '@endo/init/debug.js';
 import * as farExports from '@endo/far';
 import { isEntrypoint } from '../src/helpers/is-entrypoint.js';
@@ -63,7 +63,6 @@ export const main = async (argv, { readFile, stdout }) => {
 };
 
 if (isEntrypoint(import.meta.url)) {
-  /* global process */
   void farExports.E.when(import('fs/promises'), fsp =>
     main([...process.argv], {
       readFile: fsp.readFile,

packages/cosmic-swingset/src/anylogger-agoric.js

@@ -1,3 +1,4 @@
+/* eslint-env node */
 import {
   getEnvironmentOptionsList,
   getEnvironmentOption,

packages/cosmic-swingset/src/launch-chain.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 
 // XXX the JSON configs specify that launching the chain requires @agoric/builders,
 // so let the JS tooling know about it by importing it here.

packages/cosmic-swingset/src/sim-chain.js

@@ -1,4 +1,4 @@
-/* global process setTimeout clearTimeout */
+/* eslint-env node */
 import path from 'path';
 import fs from 'fs';
 import { Fail } from '@endo/errors';

packages/deployment/scripts/crunch.mjs

@@ -1,8 +1,7 @@
 #! /usr/bin/env node
+/* eslint-env node */
 // crunch.mjs - crunch a kvstore trace file's writes into TSV
 
-/* global process,Buffer */
-
 import fs from 'fs';
 import ReadlineTransform from 'readline-transform';
 

packages/deployment/scripts/docker-deployment.cjs

@@ -1,5 +1,5 @@
 #! /usr/bin/env node
-/* global process */
+/* eslint-env node */
 // Get a deployment.json for a 2-node docker setup.
 
 const DEFAULT_NUM_VALIDATORS = 2;

packages/deployment/src/entrypoint.js

@@ -1,6 +1,5 @@
 #! /usr/bin/env node
 /* eslint-env node */
-
 import '@endo/init';
 
 import fs from 'fs';

packages/internal/src/lib-nodejs/worker-protocol.js

@@ -1,4 +1,4 @@
-/* global Buffer */
+/* eslint-env node */
 import { Transform } from 'stream';
 
 // Transform objects which convert from hardened Arrays of JSON-serializable

packages/internal/src/netstring.js

@@ -1,4 +1,4 @@
-/* global Buffer */
+/* eslint-env node */
 import { Fail } from '@endo/errors';
 
 // adapted from 'netstring-stream', https://github.com/tlivings/netstring-stream/

packages/internal/src/node/buffer-line-transform.js

@@ -1,4 +1,4 @@
-/* global Buffer */
+/* eslint-env node */
 /* eslint-disable no-underscore-dangle */
 
 import { Transform } from 'node:stream';

packages/internal/src/node/createBundles.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 // Use modules not prefixed with `node:` since some deploy scripts may
 // still be running in esm emulation
 import path from 'path';

packages/internal/test/netstring.test.js

@@ -1,4 +1,4 @@
-/* global Buffer */
+/* eslint-env node */
 import test from 'ava';
 
 import {

packages/solo/src/init-basedir.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process */
+/* eslint-env node */
 import fs from 'fs';
 import path from 'path';
 import { execFileSync } from 'child_process';

packages/solo/src/outbound.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 import anylogger from 'anylogger';
 
 import { Fail } from '@endo/errors';

packages/solo/src/pipe-entrypoint.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 // @ts-check
 import '@endo/init/pre-bundle-source.js';
 import '@endo/init/unsafe-fast.js';

packages/solo/src/start.js

@@ -1,5 +1,5 @@
 // @ts-check
-/* global process setTimeout */
+/* eslint-env node */
 import fs from 'fs';
 import url from 'url';
 import path from 'path';

packages/solo/test/captp-fixture.js

@@ -1,4 +1,4 @@
-/* global process setTimeout */
+/* eslint-env node */
 import { spawn } from 'child_process';
 import WebSocket from 'ws';
 import { makeCapTP, E } from '@endo/captp';

packages/solo/test/home.test.js

@@ -1,4 +1,4 @@
-/* global process */
+/* eslint-env node */
 
 import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';