Why electorate didn't change in changeTwoParams test?

[simpletrontdip]

Hi, I'm diving into contractGovernor and have found changeTwoParams test case interesting.
We can vote to change the Electorate like in the previous test case changeElectorateStart, but I couldn't elaborate myself that why in this case, while changing 2 params at once, why electorate didn't change is expected.

   case 'changeTwoParams': {
      const voters1 = createVoters(firstElectorateCreatorFacet, voterCreator);

      const secondElectorateTerms = {
        committeeName: 'ThirtyCommittee',
        committeeSize: 5,
      };
      const { electorateCreatorFacet: secondElectorateCreatorFacet } =
        await startElectorate(zoe, installations, secondElectorateTerms);

      const newPoserInvitationP = E(
        secondElectorateCreatorFacet,
      ).getPoserInvitation();
      const [newPoserInvitation] = await Promise.all([newPoserInvitationP]);

      const changes = {
        [MALLEABLE_NUMBER]: 42n,
        [CONTRACT_ELECTORATE]: newPoserInvitation,
      };
      const { details: details1, outcomeOfUpdate: electorateOutcome } =
        await setupParameterChanges(
          zoe,
          log,
          governor,
          installations,
          newPoserInvitation,
          changes,
        );
      await votersVote(details1, voters1, [1, 0, 0, 0, 1]);

      await E(timer).tick();
      await E(timer).tick();
      E.when(
        electorateOutcome,
        o => log(`successful outcome: ${q(o)} `),
        e => log(`vote (unexpected) rejected outcome: ${e}`),
      );

      await validateElectorateChange(
        zoe,
        log,
        voters1,
        details1,
        governorInstance,
        // The electorate didn't change
        firstElectorateInstance,
        E(zoe).getPublicFacet(governorInstance),
      );

      break;

[dckc]

@Chris-Hibbert is it clear to you off-hand what's going on here?
or maybe @turadg ?

[Chris-Hibbert]

Ooh, good catch! That's a blatant bug in the test.

There was a missing await electorateOutcome, which allowed me to replace

        // The electorate didn't change
        firstElectorateInstance,

with secondElectorateInstance, which I initialized as on line 328.

The fix is in #5983.