Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'Interest Rate' with 'Stability Fee' in inter-protocol #7588

Open
1 of 2 tasks
otoole-brendan opened this issue May 3, 2023 · 1 comment · Fixed by #7871
Open
1 of 2 tasks

Replace 'Interest Rate' with 'Stability Fee' in inter-protocol #7588

otoole-brendan opened this issue May 3, 2023 · 1 comment · Fixed by #7871
Labels
enhancement New feature or request v1_triaged DO NOT USE

Comments

@otoole-brendan
Copy link
Contributor

otoole-brendan commented May 3, 2023 •
edited by turadg
Loading

What is the Problem Being Solved?

Similarly to #7099 - Need to change 'Interest Rate'. Product have opted for 'Stability Fee'.

Agoric/dapp-inter#108 handles the UI changes but the scope of this ticket is to update it everywhere else in the code, tests, contracts, documentation (non-user facing) etc to align.

Description of the Design

Likely a breaking change.

Replace 'Interest Rate' with 'Stability Fee' in code (might be InterestRate so StabilityFee is acceptable)

Blocked by
Beta Give feedback
  1. Upgraded stateShape may be incompatible with existing state #7337
    SwingSet bug endo liveslots
  2. lazy schema upgrade / data-migration for virtual objects #7407
    contract-upgrade
    warner

Security Considerations

N/A

Scaling Considerations

Unknown

Test Plan

TBD
@otoole-brendan otoole-brendan added enhancement New feature or request v1_triaged DO NOT USE labels May 3, 2023
@otoole-brendan otoole-brendan mentioned this issue May 3, 2023
Closed
@samsiegart samsiegart self-assigned this May 31, 2023
@samsiegart samsiegart mentioned this issue May 31, 2023
Merged
@samsiegart samsiegart mentioned this issue Jun 7, 2023
Merged
@turadg
Copy link
Member

turadg commented Jul 21, 2023

Reopening because the change had to be reverted #8084

Doing this is blocked on #7407 and #7337

@turadg turadg reopened this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v1_triaged DO NOT USE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(inter-protocol)!: rename InterestRate to StabilityFee Agoric/agoric-sdk
3 participants
@turadg @samsiegart @otoole-brendan