fix(orchestration): chainHub accepts zone #10129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
effectively commiting ourselves to the shape of the data in these maps.
This gave me pause, but it's only a commitment within a vat using a durably zoned ChainHub. We still have time to massage the shapes until the first on-chain contract using one.
That said I don't reason to expect its state schema to change.
Deploying agoric-sdk with
|
| Latest commit: |
ee4101a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b91273c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-9541-durable-chain-h.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9541
Description
Extracted the chain hub changes from #9785
Changed
makeChainHubto accept a zone instead of it implicitly creating a heap zone. A durable zone is required forretriable.Security Considerations
None
Scaling Considerations
This store the map in durable storage instead of keeping it in the heap, which uses more persistent storage.
Documentation Considerations
Not sure if any docs need to be updated besides the JS doc for
makeChainHubTesting Considerations
Updated tests and examples
Upgrade Considerations
This moves into durable storage some info that was heap only before, effectively commiting ourselves to the shape of the data in these maps.