fix(ERTP,vats): fix 9407 AmountPatternShape #9863
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f1e91c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5d74605.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-amount-shape-shape-2.agoric-sdk.pages.dev |
This was referenced Aug 7, 2024
Chris-Hibbert
approved these changes
Aug 8, 2024
erights
force-pushed
the
markm-amount-shape-shape
branch
from
e22fd40
to
7f538c6
Compare
erights
force-pushed
the
markm-amount-shape-shape-2
branch
from
b96fb18
to
b780aae
Compare
erights
force-pushed
the
markm-amount-shape-shape-2
branch
from
b780aae
to
3ee70a0
Compare
erights
force-pushed
the
markm-amount-shape-shape-2
branch
2 times, most recently
from
3a34f42
to
41b4317
Compare
erights
force-pushed
the
markm-amount-shape-shape-2
branch
from
41b4317
to
f1e91c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #9410
closes: #9407
refs: #9410
Description
Originally #9410 was supposed to fix #9407 , by relaxing an incorrect rejection into a correct acceptance. But we are not yet ready to deploy such a fix on-chain, due to upgrade constraints, so fixing it in agoric-sdk master would be misleading. It might lead people to write other code that depends on this bug being fixed when tested against agoric-sdk master, only to have that code fail later on-chain when invoking the non-upgraded buggy code.
So we unfixed #9410 to restore the buggy behavior, but with a better error message, and refactored to make fixing it again easier. This PR is that fix. It will remain draft until we are confident we can upgrade the relevant on-chain vat (the vbank) in a timely manner. Nevertheless, though we'll keep it in draft until then as a safety measure, this PR is reviewable. Reviewers, please review it.
Security Considerations
Fixing a bug is generally good for security. Otherwise, none.
Scaling Considerations
none
Documentation Considerations
Would remove the need to document the #9407 buggy behavior
Testing Considerations
Restores the
test.failingfrom #9410 to atest.Upgrade Considerations
as above.