build: avoid failure to delete Symbol.dispose using ses 0.18.5 #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50
fixes #43
to test
Run thru the getting started process but use the
dc-dispose-fix
branch at theyarn create
step:diagnosis: SES 0.18.4 and node v18.19.0 don't get along
We have seen some issues near node v18.19.0:
And now that version is in the
ghcr.io/agoric/agoric-sdk:39
image used in this dapp by way of agoric-3-proposals:https://github.com/Agoric/agoric-sdk/blob/45a954cbcbb083e756e8244240818632c1277396/packages/deployment/Dockerfile.sdk#L33-L36
that takes us to...
https://github.com/nodejs/docker-node/blob/f416b53801a9d49d6ce6b2c038c8bc9ed93625dd/18/bullseye/Dockerfile#L6
treatment: use 0.18.5
including a relevant fix: 9fb1242
reportedly 0.18.8 should work, but I haven't tested it.