Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid failure to delete Symbol.dispose using ses 0.18.5 #51

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Jan 23, 2024

fixes #50
fixes #43

to test

Run thru the getting started process but use the dc-dispose-fix branch at the yarn create step:

yarn create @agoric/dapp --dapp-template dapp-offer-up --dapp-branch dc-dispose-fix demo

diagnosis: SES 0.18.4 and node v18.19.0 don't get along

We have seen some issues near node v18.19.0:

And now that version is in the ghcr.io/agoric/agoric-sdk:39 image used in this dapp by way of agoric-3-proposals:

$ docker run --rm -ti --entrypoint=/bin/bash ghcr.io/agoric/agoric-sdk:39 
root@73e3f8a55f2a:~# node --version
v18.19.0

https://github.com/Agoric/agoric-sdk/blob/45a954cbcbb083e756e8244240818632c1277396/packages/deployment/Dockerfile.sdk#L33-L36

that takes us to...

https://github.com/nodejs/docker-node/blob/f416b53801a9d49d6ce6b2c038c8bc9ed93625dd/18/bullseye/Dockerfile#L6

ENV NODE_VERSION 18.19.0

treatment: use 0.18.5

including a relevant fix: 9fb1242

reportedly 0.18.8 should work, but I haven't tested it.

@dckc dckc merged commit 6591244 into main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants