Issue/2914 #3930
Closed
Issue/2914 #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and fix properly. |
added 2 commits
April 29, 2024 22:46
|
@geeh-xx please provide more context why you keep this based on 0.14.3 while targeting 0_15 branch. |
|
Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. |
github-actions
bot
added
the
stale
|
I see a lot of documentation and design justification (which can be part of your PR description but please don't include it into the source code repo). However on source code side, I only see a minor change to the settings page - nothing that works with the additional options in the WLED source code. Closing this PR as - obviously - work was not finished and the original author has not added anything for a long time. |
softhack007
added
the
rebase needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to issue #2914, where the user attempts to set a time for the sunrise and sunset to facilitate the system's usage. A definition has been added so that the user can input and set the custom sunrise and sunset times.