-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options for Artnet / sACN #4011
base: 0_15
Are you sure you want to change the base?
Conversation
Please rebase your PR for 0_15 branch. |
It's rather unusual for a dmx fixture to change it's whole personality based on a dmx value, that's what RDM is for. If we were to make this change then it would be nice if we could handle all possible modes than just preset/rgb |
I didn't see it as "changing the personality" (which in fact is unusual), but I see it as "integrated effect" vs "cell / pixel mode." I'll have to rebase this PR which is a bit of a pain because of the autogenerated files. |
0_15 no longer tracks autogenerated files. |
I'm really not a fan of the code duplication. (Sometimes I think copy-and-paste ought to be banned from IDEs!) I'll second the suggestion regarding supporting all possible modes instead of limiting to one or the other. Instead of special casing a couple, maybe try something like: auto activeDMXMode = DMXMode;
if (DMXMode == DMX_MODE_SELECTABLE) {
activeDMXMode = e131_data[dataOffset] / 10; // default case will catch invalid values
dataOffset += 1;
availDMXLen -= 1;
}
switch (activeDMXMode) {
// existing mode logic here
} |
This PR adds two new options to the available options for sACN / Artnet Interface.
The two new options make it possible to use Artnet to switch between Preset selection and and pixel-control.
For this the first channel is used.
If channel 1 is between 0 and 126 WLED is in Preset mode.
In this case:
Channel 2: Preset ID
Channel 3: Brightness
If channel 1 is between 127 and 255 WLED is in direct pixel mode (RGB or RGBW).
In this case:
Channel 2-4: unused
Starting from channel 5: RGB / RGBW pixel data.