Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch supported LED config from Bus #4058

Draft
wants to merge 10 commits into
base: 0_15
Choose a base branch
from

Conversation

netmindz
Copy link
Collaborator

@netmindz netmindz commented Jul 15, 2024

Following on from this PR #4056

Replace convoluted logic in settings_leds.htm with config requirements supplied in the LEDType data

Motivation - #3777

@blazoncek
Copy link
Collaborator

blazoncek commented Aug 22, 2024

@netmindz please take a look at 6f3267a
Implements similar as this PR but does not change Bus class. Instead it utilises BusManager and uses LED type convention to select appropriate GPIO text.

EDIT: There are other (mostly) irrelevant changes throughout bus_manager files to improve readability and optimise code.

@blazoncek
Copy link
Collaborator

Except for GPIO field names I think this PR has become obsolete.
Will you expand on GPIO or move that into HUB75 PR? I would prefer latter.

@netmindz
Copy link
Collaborator Author

I'll still like to remove things like IP address from the html, but certainly anything in here needs to be redone against the final bus-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants