-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Supports WHIP #1063
Replies: 7 comments · 12 replies
-
I'm glad you're on board with WHIP project. I hope someone pays attention to your WebRTC comments on the obsproject/obs-studio#7926 |
Beta Was this translation helpful? Give feedback.
All reactions
-
WHIP does not trigger AdmissionWebhook. Will this feature be added soon? |
Beta Was this translation helpful? Give feedback.
All reactions
-
The AccessControl (SignedPolicy, AdmissionWebhooks) feature in WHIP has been updated in version v0.15.7. |
Beta Was this translation helpful? Give feedback.
All reactions
-
@Baw-Appie I haven't linked webhooks and signedpolicy to WHIP yet. I will develop it. |
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 2
-
[Known Issues with OBS WHIP] [1] obsproject/obs-studio#7926 (comment)
[2] |
Beta Was this translation helpful? Give feedback.
All reactions
-
WHIP has been merged into OBS. So I expect this to be released soon. I tested with the most recent version of OBS and fixed some compatibility issues. This is available for testing with the latest master branch, and will be included in the 0.15.13 release. It works perfectly as below. Let's experience 4 frame latency. |
Beta Was this translation helpful? Give feedback.
All reactions
-
🎉 1
-
What was the minor compatibility issue? I see latest OBS-Whip build is no longer compatible with my Wowza-Whip proxy system. I guess something has changed? |
Beta Was this translation helpful? Give feedback.
All reactions
-
There were things like: |
Beta Was this translation helpful? Give feedback.
All reactions
-
Does this work when running OME inside a container? I'm trying to use OBS or Larix to use WHIP to stream to OME. The server sees the request but OBS never connects (OvenPlayer can't see this stream). And then it just disconnects. Here are my logs: ``[2023-07-21 05:20:00.421] I [SPRtcSig-t3334:12] HttpServer | http_server.cpp:149 | Client(<ClientSocket: 0x7ff78d697210, #31, Connected, TCP, Nonblocking, 172.20.0.1:48426>) is connected on *:3334 [2023-07-21 05:20:00.430] W [SPRtcSig-t3334:12] SDP | session_description.cpp:396 | Sdp parsing error : a=group:LS 0 1 [2023-07-21 05:20:00.433] I [SPRtcSig-t3334:12] Provider | stream.cpp:49 | Unknown/stream(109) has been started stream [2023-07-21 05:20:00.438] I [SPRtcSig-t3334:12] HttpServer | http_server.cpp:223 | Client(<ClientSocket: 0x7ff78d697210, #31, Disconnected, TCP, Nonblocking, 172.20.0.1:48426>) has disconnected from *:3334 [2023-07-21 05:20:31.166] I [DQICETmout:13] Transcoder | transcoder_stream.cpp:80 | [#default#app/stream(109)] Transcoder stream has been stopped Also, when specificying the IP for the ICE candidate and TCP relay IP, should I use my public IP? The lan IP of the local host? The local in the docker container? |
Beta Was this translation helpful? Give feedback.
All reactions
-
You were correct. While debugging I had accidentally rebuilt my container with an older image. I am back on the latest branch, but am still having some issues.
I notice this in my logs:
|
Beta Was this translation helpful? Give feedback.
All reactions
-
It would be good to check your OBS encode settings(keyframe i terval, preset, etc) and network condition(Udp packet loss) Refer to the manual for details. And I have experience somntimes when the dev version of OBS is not working properly, it requires PC rebooting. It may solve your problem. |
Beta Was this translation helpful? Give feedback.
All reactions
-
I am using the same encode settings as you. Restarting my computer did solve the latency. However still some issues persist: |
Beta Was this translation helpful? Give feedback.
All reactions
-
Even though WHIP streaming seems to be working. It is still working strangely. I get very poor picture quality at times, and seems to be producing a lot of errors related to "jitter". I'm not sure if this is expected behavior with WHIP/OBS, or just something related to my configuration. Here is all the information I've gathered: I've tried testing packet loss with OvenRtcTester over 45 minutes. It doesn't seem like there are any issues / very minimal packet loss:
However, I am unable to get it to test with more than 1 client even if I run this command: Also, when I use the OvenPlayer demo WebRTC tester to stream via self-signaling WSS, I experience no issues with jitter/picture quality. I'm also unable to stream to my server using Larix Broadcaster via WHIP. This hasn't been tested that I'm aware of though so it could be an incompatibility issue. So I'm not sure if this is a server configuration issue or an OBS issue.
And here is a log from a sample session with one client connecting.
|
Beta Was this translation helpful? Give feedback.
All reactions
-
The log above indicates that it took 104 packets to complete the frame, but only 99 arrived. That is, packet loss between WHIP Client and OME. This of course causes quality deterioration. If OBS supports TURN, you may be able to solve this problem by configuring it to connect over TCP. |
Beta Was this translation helpful? Give feedback.
All reactions
This discussion was converted from issue #1043 on March 09, 2023 04:41.
-
OME can now ingest streams from WHIP clients. You can test with master branch.
Using the development version of OBS is the easiest way to test the WHIP client. Download Artifacts from the URL below.
https://github.com/obsproject/obs-studio/actions/runs/3969201209
The URL format for WHIP ingest in OME is as follows:
http[s]://host[:port]/app name/stream name?direction=whip
This allows you to play live streams with End-to-End 3-5 frame latency. (About 120 ms to 150 ms)
If the latency occurs for about 1 second, it helps me to completely close OBS and relaunch it and try again.
As in the example below, if only WebRTC Provider is enabled in Server.xml, WHIP is automatically enabled. (The existing OME signaling protocol (
?direction=send
) is of course also supported at the same time.)Beta Was this translation helpful? Give feedback.
All reactions