Optionally ignore imbalanced AZs on MapNode step
#215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When restoring a cluster, the new nodes AZ distribution may not match the one stored in the backup manifest. In this case, the `MapNode` fails even though the new nodes may actually be better distributed now. The change allows mapping new nodes to their backup index in the presence of imperfect match between node AZs and backup AZs. A new exception is added to identify the imbalance error and catch it. The option to the step defaults to false so as to retain backwards compatibility with the previous behaviour. Ideally, a better solution would be to consider an AZ imbalance metric relative to some target replication factor, instead of naively remapping the backup indices. However, let's say this is good enough for the moment.
aris-aiven
force-pushed
the
aris-cassandra-ignore-imbalanced-azs
branch
from
cba6e81
to
1884bde
Compare
|
This is not a good solution, and the problem shouldn't persist the both backup and new node AZ distributions are balanced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring a cluster, the new nodes AZ distribution may not match the one stored in the backup manifest. In this case, the
MapNodefails even though the new nodes may actually be better distributed now.The change allows mapping new nodes to their backup index in the presence of imperfect match between node AZs and backup AZs. A new exception is added to identify the imbalance error and catch it.
The option to the step defaults to false so as to retain backwards compatibility with the previous behaviour.
Ideally, a better solution would be to consider an AZ imbalance metric relative to some target replication factor, instead of naively remapping the backup indices. However, let's say this is good enough for the moment.