Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Aiven user-agent #299

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

eliax1996
Copy link
Contributor

@eliax1996 eliax1996 commented Aug 7, 2023

This PR sets the user-agent header properly referred to Aiven.
Also added a micro note on code formatting in the CONTRIBUTING.md

@eliax1996 eliax1996 changed the title Added Aiven user-agent Add Aiven user-agent Aug 7, 2023
@eliax1996 eliax1996 marked this pull request as draft August 7, 2023 14:44
@eliax1996 eliax1996 force-pushed the eliax1996/add-aiven-user-agent-header branch 2 times, most recently from 0784a43 to 64e6df7 Compare August 7, 2023 14:58
@eliax1996 eliax1996 marked this pull request as ready for review August 7, 2023 15:46
@eliax1996 eliax1996 force-pushed the eliax1996/add-aiven-user-agent-header branch from 64e6df7 to 5233388 Compare August 7, 2023 15:47
@eliax1996 eliax1996 force-pushed the eliax1996/add-aiven-user-agent-header branch from 5233388 to bc7d3a1 Compare August 9, 2023 10:38
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments. And we perhaps need to figure out what's wrong with CodeQL.

@eliax1996 eliax1996 force-pushed the eliax1996/add-aiven-user-agent-header branch 2 times, most recently from 3e883f5 to 4936c67 Compare August 9, 2023 12:48
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliax1996 eliax1996 force-pushed the eliax1996/add-aiven-user-agent-header branch from 4936c67 to 3c3f525 Compare August 9, 2023 14:13
@AnatolyPopov AnatolyPopov merged commit eb0cb8e into main Aug 9, 2023
5 checks passed
@AnatolyPopov AnatolyPopov deleted the eliax1996/add-aiven-user-agent-header branch August 9, 2023 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants