This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
force-pushed
the
eliax1996/add-aiven-user-agent-header
branch
2 times, most recently
from
August 7, 2023 14:58
0784a43
to
64e6df7
Compare
eliax1996
force-pushed
the
eliax1996/add-aiven-user-agent-header
branch
from
August 7, 2023 15:47
64e6df7
to
5233388
Compare
AnatolyPopov
suggested changes
Aug 8, 2023
eliax1996
force-pushed
the
eliax1996/add-aiven-user-agent-header
branch
from
August 9, 2023 10:38
5233388
to
bc7d3a1
Compare
AnatolyPopov
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments. And we perhaps need to figure out what's wrong with CodeQL.
eliax1996
force-pushed
the
eliax1996/add-aiven-user-agent-header
branch
2 times, most recently
from
August 9, 2023 12:48
3e883f5
to
4936c67
Compare
AnatolyPopov
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eliax1996
force-pushed
the
eliax1996/add-aiven-user-agent-header
branch
from
August 9, 2023 14:13
4936c67
to
3c3f525
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
user-agent
header properly referred to Aiven.Also added a micro note on code formatting in the
CONTRIBUTING.md