Skip to content

Commit

Permalink
Merge pull request #320 from aiven/jongiddy-master-eligibility
Browse files Browse the repository at this point in the history
Fix spelling of eligibility, clarify docs
  • Loading branch information
tvainika authored Feb 3, 2022
2 parents 7626aec + 9a1439c commit de400ba
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,9 @@ Keys to take special care are the ones needed to configure Kafka and advertised_
coordination among the Karapace instances.
* - ``client_id``
- ``sr-1``
- The ``client_id`` name by which the Karapace will use when coordinating with
other Karapaces who is master. The one with the name that sorts as the
first alphabetically is chosen as master from among the services with
- The ``client_id`` Karapace will use when coordinating with
other Karapace instances. The instance with the ID that sorts
first alphabetically is chosen as master from the services with
master_eligibility set to true.
* - ``consumer_enable_autocommit``
- ``True``
Expand All @@ -337,10 +337,10 @@ Keys to take special care are the ones needed to configure Kafka and advertised_
- The Kafka group name used for selecting a master service to coordinate the storing of Schemas.
* - ``master_eligibility``
- ``true``
- Should the service instance be considered for promotion to be the master
service. Reason to turn this off would be to have an instances of Karapace
- Should the service instance be considered for promotion to the master
service. One reason to turn this off would be to have an instance of Karapace
running somewhere else for HA purposes but which you wouldn't want to
automatically promote to master if the primary instances were to become
automatically promote to master if the primary instances become
unavailable.
* - ``producer_compression_type``
- ``None``
Expand Down
2 changes: 1 addition & 1 deletion container/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ services:
KARAPACE_HOST: 0.0.0.0
KARAPACE_CLIENT_ID: karapace
KARAPACE_GROUP_ID: karapace-registry
KARAPACE_MASTER_ELIGIBITY: "true"
KARAPACE_MASTER_ELIGIBILITY: "true"
KARAPACE_TOPIC_NAME: _schemas
KARAPACE_LOG_LEVEL: WARNING
KARAPACE_COMPATIBILITY: FULL
Expand Down
2 changes: 1 addition & 1 deletion container/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ case $1 in
[[ -n "${KARAPACE_REGISTRY_PORT+isset}" ]] && export KARAPACE_PORT="${KARAPACE_REGISTRY_PORT}"
[[ -n "${KARAPACE_REGISTRY_CLIENT_ID+isset}" ]] && export KARAPACE_CLIENT_ID="${KARAPACE_REGISTRY_CLIENT_ID}"
[[ -n "${KARAPACE_REGISTRY_GROUP_ID+isset}" ]] && export KARAPACE_GROUP_ID="${KARAPACE_REGISTRY_GROUP_ID}"
[[ -n "${KARAPACE_REGISTRY_MASTER_ELIGIBITY+isset}" ]] && export KARAPACE_MASTER_ELIGIBILITY="${KARAPACE_REGISTRY_MASTER_ELIGIBITY}"
[[ -n "${KARAPACE_REGISTRY_MASTER_ELIGIBILITY+isset}" ]] && export KARAPACE_MASTER_ELIGIBILITY="${KARAPACE_REGISTRY_MASTER_ELIGIBILITY}"
[[ -n "${KARAPACE_REGISTRY_TOPIC_NAME+isset}" ]] && export KARAPACE_TOPIC_NAME="${KARAPACE_REGISTRY_TOPIC_NAME}"
[[ -n "${KARAPACE_REGISTRY_COMPATIBILITY+isset}" ]] && export KARAPACE_COMPATIBILITY="${KARAPACE_REGISTRY_COMPATIBILITY}"
[[ -n "${KARAPACE_REGISTRY_LOG_LEVEL+isset}" ]] && export KARAPACE_LOG_LEVEL="${KARAPACE_REGISTRY_LOG_LEVEL}"
Expand Down

0 comments on commit de400ba

Please sign in to comment.