karapace: avoid starting until topic its successfully created #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the underlying `create_topics` function unless the `operation_timeout` its async (the effects of this call aren't immediately visible after the call its performed), if karapace its started on a cluster that its slow enough in creating the topic, we get an unhandled exception in the startup of the service of type: ``` aiokafka.errors.UnknownTopicOrPartitionError: [Error 3] UnknownTopicOrPartitionError ``` The fix its simple, try to query from the cluster (immediately after having commanded the creation of the topic) the offsets of the topic. If the returned status its `OFFSET_UNINITIALIZED` we simply need to try again shortly later.
eliax1996
force-pushed
the
eliax1996/unknown-topic-shouldnt-affect-start-of-karapace
branch
2 times, most recently
from
7b969af
to
0e18cba
Compare
eliax1996
force-pushed
the
eliax1996/unknown-topic-shouldnt-affect-start-of-karapace
branch
from
0e18cba
to
e8467ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the underlying
create_topicsfunction unless theoperation_timeoutits async (the effects of this call aren't immediately visible after the call its performed), if karapace its started on a cluster that its slow enough in creating the topic, we get an unhandled exception in the startup of the service of type:The fix its simple, try to query from the cluster (immediately after having commanded the creation of the topic) the offsets of the topic. If the returned status its
OFFSET_UNINITIALIZEDwe simply need to try again shortly later.About this change - What it does
References: #xxxxx
Why this way