Introduce protobuf formatter #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keejon
force-pushed
the
keejon/protobuf-formatter-normalization
branch
10 times, most recently
from
2892b47
to
353fd7c
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
keejon
commented
Aug 16, 2024
| } | ||
|
|
||
| extend Foo { | ||
| option (my_option) = "my_value"; |
There was a problem hiding this comment.
Removed this because extending with options seems to be invalid proto.
keejon
force-pushed
the
keejon/protobuf-formatter-normalization
branch
3 times, most recently
from
70dc909
to
8833da7
Compare
keejon
force-pushed
the
keejon/protobuf-formatter-normalization
branch
2 times, most recently
from
41ece6c
to
6a5731d
Compare
Protobuf formatter is written in go and based on the buf formatter. It is installed as Extension and introduces go as dependency. If enabled it will run on top and independent of normalization.
keejon
force-pushed
the
keejon/protobuf-formatter-normalization
branch
from
6a5731d
to
6d954e6
Compare
jjaakola-aiven
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This PR adds an optional formatter for protobuf schemas.
Protobuf formatter is written in go and based on the buf formatter. It is installed as Extension and introduces go as dependency. If enabled it will run on top and independent of normalization.
Why this way
Karapace protobuf normalization is not feature complete which can lead to issues if e.g. different Kafka producers are used.
This is a short term fix for those issues.
In the future either normalization will have to be improved or moved entirely to go/protocompile/buf.