-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add systemd journal logging configuration #946
Merged
eliax1996
merged 1 commit into
main
from
jjaakola-aiven-add-systemd-journal-logging-config
Oct 9, 2024
Merged
feat: add systemd journal logging configuration #946
eliax1996
merged 1 commit into
main
from
jjaakola-aiven-add-systemd-journal-logging-config
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
28 times, most recently
from
September 13, 2024 11:32
884f19d
to
e0f5304
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
9 times, most recently
from
September 17, 2024 08:24
ff223f8
to
749fcd0
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
2 times, most recently
from
September 30, 2024 09:30
0337e7f
to
618ab23
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
from
October 1, 2024 07:58
618ab23
to
3b06e6d
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
from
October 4, 2024 08:23
3b06e6d
to
a7d45b8
Compare
eliax1996
reviewed
Oct 8, 2024
eliax1996
reviewed
Oct 8, 2024
eliax1996
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the comments that are optional/non blocking LGTM
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-systemd-journal-logging-config
branch
from
October 9, 2024 11:04
a7d45b8
to
5bf7212
Compare
eliax1996
approved these changes
Oct 9, 2024
eliax1996
deleted the
jjaakola-aiven-add-systemd-journal-logging-config
branch
October 9, 2024 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Add configurability for logging handlers. The supported handlers are StreamHandler and systemd.journal.JournalHandler.
The log level is preserved for journal as log is written in structured format for journald.
Requires #947 first.
References: #xxxxx
Why this way