Migrate to pyproject toml #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
3d3f5fa
to
9cd287f
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
9cd287f
to
0d8bec6
Compare
aiven-anton
reviewed
Sep 13, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
0d8bec6
to
e51b148
Compare
aiven-anton
reviewed
Sep 13, 2024
aiven-anton
previously approved these changes
Sep 13, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
e51b148
to
f928bde
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
11 times, most recently
from
8cf0213
to
cca1197
Compare
aiven-anton
reviewed
Sep 13, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
cca1197
to
03cb394
Compare
|
The JSON serialization tests failed. This seems, to me, like an odd one to fail. Does this change impact JSON serialization or is the JSON serialization test flaky? |
|
@Claudenw config file reading and parsing failed. The file (fixture) is created here: https://github.com/Aiven-Open/karapace/blob/main/tests/conftest.py#L163 |
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
3 times, most recently
from
fc23c8c
to
0a4e8d2
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
17 times, most recently
from
00e7ae9
to
9989b50
Compare
| pip install -r ./requirements/requirements-dev.txt | ||
| pip install -e . | ||
| pip install . | ||
| pip install -e .[dev,typing] |
There was a problem hiding this comment.
In my zsh terminal I had to add quotes because of the squared brackets:
pip install -e ".[dev,typing]"
jjaakola-aiven
force-pushed
the
jjaakola-aiven-migrate-to-pyproject-toml
branch
from
9989b50
to
d2cc568
Compare
keejon
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
First commit migrates to use
pyproject.toml. Build backend is still thesetuptools.Karapace install:
pip install .Editable install for development:
pip install -e .[dev,typing] Building the wheel:python -m buildPinning of dependencies to:make pin-requirements. Pinning runs thepip-compilein a Python 3.8 container. Version is now created bysetuptools-scm` from git state and is PEP compliant.The second commit migrates to source layout.
The third commit cleans the Github links from
aivenorganization toAiven-Open.The fourth commit removes the
pyenvrequirement. Proposal is to implement and usetoxlater on for multiversion testing locally.References: #xxxxx
Why this way