schema-reader: Log the erroring kafka message key #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosahama
force-pushed
the
nosahama/log-msg-key-on-schema-reader-error
branch
from
515f785
to
a43b230
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Left a comment but LGTM |
- we add the kafka message key to the log in the case of an error, this makes it easier to debug issues - we also add a check for kafka messages without a key
nosahama
force-pushed
the
nosahama/log-msg-key-on-schema-reader-error
branch
from
a43b230
to
25889f0
Compare
aiven-anton
reviewed
Sep 25, 2024
Comment on lines
+366
to
+370
| except AssertionError as exc: | ||
| LOG.warning("Empty msg.key() at offset %s", msg.offset()) | ||
| self.offset = msg.offset() # Invalid entry shall also move the offset so Karapace makes progress. | ||
| self.kafka_error_handler.handle_error(location=KafkaErrorLocation.SCHEMA_READER, error=exc) | ||
| continue # [non-strict mode] |
There was a problem hiding this comment.
Hmm, this looks like a bit of a sketchy idea, an AssertionError could come from deeper in the code, and this essentially abuses the assert to function as a goto. AssertionError should really never be caught, bar some special cases in test harnessing code.
There was a problem hiding this comment.
If an AssertionError is raised from msg.key() or msg.error(), the correct behavior is for the code to fall over, and be restarted by the scheduler.
There was a problem hiding this comment.
Yes this had existed prior to this change, we can take a look later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does